-
Notifications
You must be signed in to change notification settings - Fork 21
fix(experimental): Add ldmiddleware library, utilities for creating scoped clients, contexts, events automatically #306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
093094e
to
b203ea2
Compare
ember-stevens
approved these changes
Aug 19, 2025
keelerm84
reviewed
Aug 19, 2025
Co-authored-by: Matthew M. Keeler <[email protected]>
keelerm84
approved these changes
Aug 20, 2025
This was referenced Aug 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new
ldmiddleware
library which provides four HTTP middlewares that can help jumpstart a LaunchDarkly setup:AddScopedClientForRequest
- creates a scoped client and adds ald_request
-kind context to it, an anonymous context populated with various attributes of the incoming HTTP requestAddScopedClientForRequestWithKeyFn
- same except you provide a custom function for determining thekey
of each request contextTrackTiming
- track duration metrics using whatever contexts are set so far in the scoped clientTrackErrorResponses
- track 4xx & 5xx error responses using whatever contexts are set so far in the scoped clientSee README.md for sample usage.
Note that these functions are simple enough that consumers could implement their own versions of these if they want the behavior to be slightly different. However, I've set the initial library version as
0.1.0
and am advertising it as an an "alpha" state so we're free to keep making changes.